[PATCH] D68766: [NFC][ArgPromo][Tests] Run update_test_checks on all ArgumentPromotion tests

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -argpromotion -S | FileCheck %s
+; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefix=ATTRIBUTOR
 
----------------
Do you want:
```
; RUN: opt < %s -argpromotion -S | FileCheck %s --check-prefixes=ALL,ARGPROMOTION
; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefixes=ALL,ATTRIBUTOR
```
?


================
Comment at: llvm/test/Transforms/ArgumentPromotion/musttail.ll:45
 define internal i32 @test2(%T* %p, i32 %p2) {
+; CHECK-LABEL: define internal i32 @test2(%T* %p, i32 %p2)
+; CHECK-NEXT:    [[A_GEP:%.*]] = getelementptr [[T:%.*]], %T* [[P:%.*]], i64 0, i32 3
----------------
does the script produce these verbose check-lines for define?
I think i usually saw it producing just the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68766/new/

https://reviews.llvm.org/D68766