[PATCH] D68686: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 18:04:00 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fp-strict-avx.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx2 -O3 | FileCheck %s --check-prefixes=CHECK,X86
----------------
We tend to prefer to split tests by vector width rather than features. So we should have 128-bit test with sse, avx, and avx512 command lines. A 256-bit test with avx and avx512 command lines. And a 512-bit test with avx512 command line. This way we can make sure a given function is generated in a similar way for all isas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68686/new/

https://reviews.llvm.org/D68686





More information about the llvm-commits mailing list