[PATCH] D68621: [sanitizer_common] Remove OnPrint from Go build.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 16:03:34 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build. (authored by morehouse).
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68621/new/

https://reviews.llvm.org/D68621

Files:
  compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp


Index: compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp
===================================================================
--- compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp
+++ compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp
@@ -229,8 +229,6 @@
 // Can be overriden in frontend.
 #if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
 // Implementation must be defined in frontend.
-// TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
-extern "C" void OnPrint(const char *str);
 extern "C" void __sanitizer_on_print(const char *str);
 #else
 SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_on_print, const char *str) {
@@ -239,10 +237,6 @@
 #endif
 
 static void CallPrintfAndReportCallback(const char *str) {
-#if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
-  // TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
-  OnPrint(str);
-#endif
   __sanitizer_on_print(str);
   if (PrintfAndReportCallback)
     PrintfAndReportCallback(str);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68621.224194.patch
Type: text/x-patch
Size: 1005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191009/0b98cefc/attachment.bin>


More information about the llvm-commits mailing list