[PATCH] D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:836
+    LLVM_DEBUG(
+        !(MO.isGlobal() && Subtarget->isGVIndirectSymbol(MO.getGlobal())) &&
+        "Interposable definitions must use indirect access.");
----------------
Missing the invocation of `assert` here?


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1377
 
-    for (MapVector<MCSymbol*, MCSymbol*>::iterator I = TOC.begin(),
+    for (MapVector<const MCSymbol*, MCSymbol*>::iterator I = TOC.begin(),
          E = TOC.end(); I != E; ++I) {
----------------
Has a range-based for loop been considered?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68721/new/

https://reviews.llvm.org/D68721