[PATCH] D68699: [ARM] Add some sample IR MVE intrinsics with C++ isel.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 07:49:01 PDT 2019


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:2381
+  int32_t ImmValue = cast<ConstantSDNode>(N->getOperand(3))->getZExtValue();
+  Ops.push_back(getI32Imm(ImmValue, Loc)); // immediate offset
+
----------------
The immediate is in the range +-128? Do we need to diagnose here when that is out of range? Is it already diagnosed by the front end?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68699/new/

https://reviews.llvm.org/D68699





More information about the llvm-commits mailing list