[PATCH] D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 01:15:40 PDT 2019


gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/lib/Analysis/Loads.cpp:48
+  return false;
 }
 
----------------
jdoerfert wrote:
> While I'm all for making the "getAlign" function explicit eventually, I think it would be good to keep it as is for this patch as there doesn't seem to be a reason to do this here. 
> 
> fwiw: I'm behind but eventually I was going to refactor this: D66618
> 
Which function are you talking about exactly? I don't see a `getAlign` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68398/new/

https://reviews.llvm.org/D68398





More information about the llvm-commits mailing list