[PATCH] D68646: [llvm-exegesis] Explore LEA addressing modes.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-exegesis/lib/RegisterAliasing.h:106
 
+// a = a & ~b;
+inline void remove(llvm::BitVector &A, const llvm::BitVector &B) {
----------------
Why not implement it this way ? Is this because of knowledge that B has few bits set?


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:181
 
+// Helper to fill a mempry operand with a value.
+static void setMemOp(InstructionTemplate &IT, int OpIdx,
----------------
typo


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:217
+      for (int LogScale = 0; LogScale <= 3; ++LogScale) {
+        for (const int Disp : {0, 42}) {
+          InstructionTemplate IT(Instr);
----------------
You should provide a rationale for why only `{0, 42}`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68646/new/

https://reviews.llvm.org/D68646