[PATCH] D68352: [lld] Don't create hints-section if Hint/Name Table is empty

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 22:44:30 PDT 2019


ruiu added a comment.

Build reproducibility (a property that if you feed the exact same inputs to compilers or linkers you can get the exact same output) is important. Unfrotunately, by default, COFF has a timestamp field that changes virtually every time, but it looks like the difference between you and me is a difference how things are laid out in the file. That is not supposed to vary.

We can just ignore the line and check only the following three lines

1. CHECK-NEXT:     DLL Name: test.dll
2. CHECK-NEXT:     Hint/Ord  Name
3. CHECK-NEXT:            1

but I'd like to understand what is going on. Are you at the repo head?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68352/new/

https://reviews.llvm.org/D68352





More information about the llvm-commits mailing list