[PATCH] D68352: [lld] Don't create hints-section if Hint/Name Table is empty

Tue Oct 8 19:30:06 PDT 2019

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lld/test/COFF/imports-ordinal-only.s:5
+# RUN: llvm-mc -triple=i386-pc-win32 %s -filetype=obj -o %t.obj
+# RUN: lld-link -out:%t.exe -entry:main -subsystem:console -safeseh:no -debug %t.obj %t-implib.a
+
----------------
thrimbor wrote:
> ruiu wrote:
> > I'd dump the import table to verify that a correct import table is actually created in the resulting executable.
> I updated the test. Is this what you had in mind?
Yes, but please add `--match-full-lines` to FileCheck so that if Name exists in an actual output the test will fail. By default, if an actual output is a substring of a CHECK line, it will succeed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68352/new/

https://reviews.llvm.org/D68352