[PATCH] D68672: [APInt] Rounding right-shifts

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a reviewer: timshen.
lebedev.ri marked an inline comment as done.
lebedev.ri added a subscriber: timshen.
lebedev.ri added inline comments.


================
Comment at: llvm/unittests/ADT/APIntTest.cpp:2529-2538
+        EXPECT_TRUE(Prod.sge(A));
+        if (Prod.sgt(A)) {
           EXPECT_TRUE(((Quo - 1).sext(16) * B.sext(16)).ult(A));
         }
       }
       {
         APInt Quo = APIntOps::RoundingSDiv(A, B, APInt::Rounding::DOWN);
----------------
@sanjoy @timshen FIXME: that's the intended check, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68672/new/

https://reviews.llvm.org/D68672