[PATCH] D68668: [lit] Extend internal diff to support -U

[Joel E. Denny via Phabricator via llvm-commits]

jdenny created this revision.
jdenny added reviewers: probinson, stella.stamenova, bd1976llvm, jlpeyton, rnk, mgorny.
Herald added a subscriber: delcypher.
Herald added a project: LLVM.
jdenny added a parent revision: D67643: [lit] Extend internal diff to support `-` argument.
jdenny added a child revision: D66506: [lit] Fix internal env calling other internal commands.

When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:

  # RUN: program | diff -U1 file -

Such cases exist now, in `clang/test/Analysis` for example.  We are 
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` doesn't
recognize `-U` as a command-line option.  This patch adds `-U`
support.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68668

Files:
  llvm/utils/lit/lit/builtin_commands/diff.py
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
  llvm/utils/lit/tests/max-failures.py
  llvm/utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68668.223948.patch
Type: text/x-patch
Size: 7015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191008/90a1ca6f/attachment.bin>