[PATCH] D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC.

Tue Oct 8 13:15:00 PDT 2019

mstorsjo added a comment.

In D68133#1700289 <https://reviews.llvm.org/D68133#1700289>, @mstorsjo wrote:

> In D68133#1700276 <https://reviews.llvm.org/D68133#1700276>, @thakis wrote:
>
> > That links is dead. Which customization is needed here?
>
>
> Ah crap, I should have quoted the relevant bits...
>
> IIRC, it at least had extra `public:` at the start of the symbol, extra return type and calling convention specifiers. D68134 <https://reviews.llvm.org/D68134> has a more concrete case of what needs to change in LLDB if the llvm demangler is used as-is there.

I guess ideally we would have individual flags for all the UnDecorateSymbolName flags used here: `UNDNAME_NO_ACCESS_SPECIFIERS`, `UNDNAME_NO_ALLOCATION_LANGUAGE`, `UNDNAME_NO_THROW_SIGNATURES`, `UNDNAME_NO_MEMBER_TYPE`, `UNDNAME_NO_MS_KEYWORDS`, `UNDNAME_NO_FUNCTION_RETURNS`.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68133/new/

https://reviews.llvm.org/D68133