[PATCH] D66969: Output XCOFF object text section header and symbol entry for program code

Tue Oct 8 10:48:07 PDT 2019

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.

================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:357
+  // Now output the auxiliary entry.
+  W.write<uint32_t>(CSectionRef.SymbolTableIndex);
+  // Parameter typecheck hash. Not supported.
----------------
hubert.reinterpretcast wrote:
> sfertile wrote:
> > hubert.reinterpretcast wrote:
> > > Since the field is named `SectionLen` in `llvm::object::XCOFFCsectAuxEnt32`, a comment is warranted regarding its use also for referencing the containing csect by symbol table index. Please also add a comment in `include/llvm/Object/XCOFFObjectFile.h`.
> > I'm not disagreeing with this, but it should be done in a separate patch. 
> @DiggerLin, please post such a patch (perhaps going so far as to rename the field to `SectionOrLength`) so we do not lose track of this.
I created a NFC patch. https://reviews.llvm.org/D68650 

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66969/new/

https://reviews.llvm.org/D66969