[PATCH] D68611: [IRGen] Emit lifetime markers for temporary struct allocas

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 10:06:51 PDT 2019


rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:4014
+          if (LifetimeSize) // In case we disabled lifetime markers.
+            CallLifetimeEndAfterCall.emplace_back(AI, LifetimeSize);
+
----------------
Please push this immediately after emitting the lifetime start.  That'll just make it more obvious that the `copyInto` call doesn't affect this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68611/new/

https://reviews.llvm.org/D68611





More information about the llvm-commits mailing list