[PATCH] D68636: [llvm-readobj] - Refine the LLVM-style output to be consistent.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:5598
                                                 const Elf_Shdr *Sec) {
-  DictScope SS(W, "Version symbols");
+  ListScope SS(W, "VersionSymbols");
   if (!Sec)
----------------
grimar wrote:
> jhenderson wrote:
> > Ditto, though I'm wondering here why the VersionSymbols data includes stuff to do with its section header? If it didn't have that stuff, it would be a list.
> > though I'm wondering here why the VersionSymbols data includes stuff to do with its section header?
> 
> I do not know. The same information is printed under "Sections [" tag anyways, so it is not useful probably:
> 
> ```
>   Section {
>     Index: 3
>     Name: .gnu.version (30)
>     Type: SHT_GNU_versym (0x6FFFFFFF)
>     Flags [ (0x0)
>     ]
>     Address: 0x0
>     Offset: 0xB4
>     Size: 2
>     Link: 0
>     Info: 0
>     AddressAlignment: 0
>     EntrySize: 2
>   }
> ```
> 
> Should we remove "Section Name"/"Address"/"Offset"/"Link" and make it to be a list?
I'd be inclined to do that personally, but it should be a separate change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68636/new/

https://reviews.llvm.org/D68636