[PATCH] D68629: [llvm-exegesis] Finish plumbing the `Config` field.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 01:54:26 PDT 2019


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Clustering.cpp:241
+  // Given an instruction Opcode and Config, in which clusters do benchmarks of
+  // this instruction lie? Normally, they all should be in the same cluster.
+  struct OpcodeAndConfig {
----------------
gchatelet wrote:
> Not related to this patch but why a question mark here?
Not sure, but that doe snot bother me too much :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68629/new/

https://reviews.llvm.org/D68629





More information about the llvm-commits mailing list