[PATCH] D68620: DebugInfo: Use base address selection entries for debug_loc

[David Blaikie via Phabricator via llvm-commits]

dblaikie created this revision.
dblaikie added reviewers: labath, probinson, aprantl.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Unify the range and loc emission (for both DWARFv4 and DWARFv5 style lists) and take advantage of that unification to use strategic base addresses for loclists.

Needs more testing, but llvm-dwarfdump doesn't currently support LLE_base_addressx, for instance. But Pavel's looking at some changes there, so I'm holding off in case his work addresses it, or at least I can work on it afterwards so as not to conflict if I tried to do so now.

Anyone know whether they have consumers (LLDB, the Sony debugger) that would need to be updated for either the v4 changes (use of base address specifiers in classic debug_loc lists) or v5 (base_addressx, etc, etc)? GDB can't cope with the DWARFv5 stuff, but seems fine with the v4 version.


Repository:
  rL LLVM

https://reviews.llvm.org/D68620

Files:
  include/llvm/BinaryFormat/Dwarf.def
  include/llvm/BinaryFormat/Dwarf.h
  lib/BinaryFormat/Dwarf.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
  test/DebugInfo/X86/sret.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68620.223716.patch
Type: text/x-patch
Size: 17353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191008/17236727/attachment.bin>