[PATCH] D68600: AMDGPU/GlobalISel: Fix crash on wide constant load with VGPR pointer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 15:07:10 PDT 2019


arsenm created this revision.
arsenm added reviewers: tstellar, nhaehnle, kerbowa.
Herald added subscribers: Petar.Avramovic, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.

This was ignoring the register bank of the input pointer, and
isUniformMMO seems overly aggressive.

      

This will now conservatively assume a VGPR in cases where the incoming
 bank hasn't been determined yet (i.e. is from a loop phi).


https://reviews.llvm.org/D68600

Files:
  lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  test/CodeGen/AMDGPU/GlobalISel/legalize-extract.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68600.223669.patch
Type: text/x-patch
Size: 4604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191007/3c6d7384/attachment.bin>


More information about the llvm-commits mailing list