[PATCH] D68472: [test] Depend on C.UTF-8 dependency for mri-utf8.test

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D68472#1697691 <https://reviews.llvm.org/D68472#1697691>, @hubert.reinterpretcast wrote:

> Thanks for adding the BOM. With the BOM, would it make sense to leave `mri-utf8.test` as the name of the file?


I think the testfile name should reflect what is being tested since that's the test identifier (ie. when a test fails lit prints the relative filepath) so the fact that the file is encoded in UTF-8 is irrelevant. Here the test is about llvm-ar handling non ascii filename, as the first comment explains it. How is the <pound sign>.txt file encoded would make a bit more sense as a name but then as I mentioned AFAIK the filename is encoded in UTF-16 on Windows anywat. In summary, I think the renaming is warranted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68472/new/

https://reviews.llvm.org/D68472