[PATCH] D67882: [LNT] Python 3 support: remove useless var-setting getter

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D67882#1697713 <https://reviews.llvm.org/D67882#1697713>, @hubert.reinterpretcast wrote:

> In D67882#1697616 <https://reviews.llvm.org/D67882#1697616>, @thopre wrote:
>
> > I think we should make LNT Python 3 only as soon as it can work in that mode, so the less compability code we can add the better. Do you agree with that approach?
>
>
> I agree with the approach of minimizing compatibility code. I am not sure about proactively dropping Python 2 support. As you said, the amount of commits going into LNT is low, so keeping Python 2 compatibility once the Python 3 mode works won't cost much development effort.


It's not so much the development effort rather than the risk of introducing python2- or python3-specific code without noticing. Since LNT is an application so has no problem of reverse dependences and Python 2 becomes EOL in 2 months I feel like a migration allows to quickly remove the compatibility added without much downside. But either way it doesn't impact the amount of effort to migrate so I'm fine with whatever is decided.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67882/new/

https://reviews.llvm.org/D67882