[PATCH] D68484: [PATCH 01/38] [noalias] LangRef: noalias intrinsics and noalias_sidechannel documentation.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/docs/LangRef.rst:16269
+The ``llvm.noalias`` intrinsic introduces alias assumptions in the normal
+computation path  of a pointer and it will be opaque for most optimizations. The
+``PropagateAndConvertNoAlias`` pass converts ``llvm.noalias`` intrinsics into
----------------
Extra space after "path"


================
Comment at: llvm/docs/LangRef.rst:16272
+``llvm.side.noalias`` intrinsics. At the same time, it splits the pointer path
+in a computation path (without ``llvm.noalias`` intrinsics) and a
+``noalias_sidechannel`` path (with ``llvm.side.noalias`` intrinsics). This
----------------
in -> into?


================
Comment at: llvm/docs/LangRef.rst:16289
+The ``llvm.noalias.copy.guard`` intrinsic is used to annotate that the returned
+pointer points to a blob of memory that contains restrict pointers. This allows
+to track the *based on* dependency when copying such blocks of memory.
----------------
"allows to track" reads funny. Maybe "allows tracking of"?


================
Comment at: llvm/docs/LangRef.rst:16295
+
+Following arguments are typically used in the various intrinscis:
+
----------------
intrinsics*


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68484/new/

https://reviews.llvm.org/D68484