[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 10:00:17 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/trunk/include/llvm-c/Core.h:1523-1524
       macro(UndefValue)                     \
     macro(Instruction)                      \
       macro(BinaryOperator)                 \
       macro(CallInst)                       \
----------------
cameron.mcinally wrote:
> cameron.mcinally wrote:
> > lebedev.ri wrote:
> > > @cameron.mcinally Should anything have been added here for `UnaryOperator` ? 
> > Yes, I believe you're correct. Will add that under a separate Diff. Thanks.
> @lebedev.ri, do you know of any existing tests for these macros? I see a number of uses, but no unittests/etc.
I don't know how this can be reached, but based on the name (`LLVMCCoreValues`) i can guess this is for C API.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53877/new/

https://reviews.llvm.org/D53877





More information about the llvm-commits mailing list