[PATCH] D67529: [TextAPI] Introduce TBDv4

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 09:55:45 PDT 2019


ributzka added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/Target.cpp:35
+                 .Case("bridgeos", PlatformKind::bridgeOS)
+                 .Case("maccatalyst", PlatformKind::macCatalyst)
+                 .Default(PlatformKind::unknown);
----------------
Sorry, I just noticed that the simulators are missing in this list. Please add support for them and also matching tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67529/new/

https://reviews.llvm.org/D67529





More information about the llvm-commits mailing list