[PATCH] D67882: [LNT] Python 3 support: make leaf classes inherit from object

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 07:38:50 PDT 2019


thopre updated this revision to Diff 223603.
thopre added a comment.

Remove class style compability change
Remove stddev_mean property code altogether since it is not used anywhere


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67882/new/

https://reviews.llvm.org/D67882

Files:
  lnt/server/reporting/analysis.py


Index: lnt/server/reporting/analysis.py
===================================================================
--- lnt/server/reporting/analysis.py
+++ lnt/server/reporting/analysis.py
@@ -97,7 +97,6 @@
             self.stddev = None
             self.MAD = None
 
-        self.stddev_mean = None  # Only calculate this if needed.
         self.failed = cur_failed
         self.prev_failed = prev_failed
         self.samples = samples
@@ -106,14 +105,6 @@
         self.confidence_lv = confidence_lv
         self.bigger_is_better = bigger_is_better
 
-    @property
-    def stddev_mean(self):
-        """The mean around stddev for current sampples. Cached after first call.
-        """
-        if not self.stddev_mean:
-            self.stddev_mean = stats.mean(self.samples)
-        return self.stddev_mean
-
     def __repr__(self):
         """Print this ComparisonResult's constructor.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67882.223603.patch
Type: text/x-patch
Size: 899 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191007/1b6a4dea/attachment.bin>


More information about the llvm-commits mailing list