[PATCH] D67968: [TableGen] Introduce a generic automaton (DFA) backend

[Mikael Holmén via llvm-commits]

Sounds good!

Thanks,
Mikael

________________________________________
From: James Molloy <jmolloy at google.com>
Sent: Monday, October 7, 2019 9:08 AM
To: reviews+D67968+public+7a365629e84f6a39 at reviews.llvm.org
Cc: Tim Northover; daniel_l_sanders at apple.com; david.majnemer at gmail.com; Mikael Holmén; wan.yu at ibm.com; llvm-dev at redking.me.uk; notstina at gmail.com; mgorny at gentoo.org; llvm-commits at lists.llvm.org; jun.l at samsung.com
Subject: Re: [PATCH] D67968: [TableGen] Introduce a generic automaton (DFA) backend

Thanks Mikael,

That looks easier than plumbing the type name into that code. And thanks for pointing at the bot , I will commit the change and watch it for greenness.

(Just arriving into work, was going to look at this in a few minutes anyway :))

On Mon, 7 Oct 2019, 07:47 Mikael Holmén via Phabricator, <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
uabelho added a comment.

clang-cuda-build buildbot failed too:
http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37865/steps/ninja%20check%201/logs/stdio<https://protect2.fireeye.com/url?k=3eaf8709-627b8fa0-3eafc792-865b3b1e120b-e3aaf7e3972fdeb6&q=1&u=http%3A%2F%2Flab.llvm.org%3A8011%2Fbuilders%2Fclang-cuda-build%2Fbuilds%2F37865%2Fsteps%2Fninja%2520check%25201%2Flogs%2Fstdio>

I think it can be fixed with

  @@ -371,20 +371,20 @@ uint64_t Transition::transitionFrom(uint64_t State) {
   void CustomDfaEmitter::printActionType(raw_ostream &OS) { OS << TypeName; }

   void CustomDfaEmitter::printActionValue(action_type A, raw_ostream &OS) {
     const ActionTuple &AT = Actions[A];
     if (AT.size() > 1)
  -    OS << "{";
  +    OS << "std::make_tuple(";
     bool First = true;
     for (const auto &SingleAction : AT) {
       if (!First)
         OS << ", ";
       First = false;
       SingleAction.print(OS);
     }
     if (AT.size() > 1)
  -    OS << "}";
  +    OS << ")";
   }

   namespace llvm {

   void EmitAutomata(RecordKeeper &RK, raw_ostream &OS) {

similar to the fix in r372384 (169cb6347 <https://reviews.llvm.org/rG169cb63478aa047451786d8ccf6af4b721e3b271<https://protect2.fireeye.com/url?k=9e565621-c2825e88-9e5616ba-865b3b1e120b-24662a41c1eb88f2&q=1&u=https%3A%2F%2Freviews.llvm.org%2FrG169cb63478aa047451786d8ccf6af4b721e3b271>>).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67968/new/<https://protect2.fireeye.com/url?k=622baf32-3effa79b-622befa9-865b3b1e120b-8f798bab20f931c5&q=1&u=https%3A%2F%2Freviews.llvm.org%2FD67968%2Fnew%2F>

https://reviews.llvm.org/D67968<https://protect2.fireeye.com/url?k=2a9625ef-76422d46-2a966574-865b3b1e120b-3d45662af73ae8b6&q=1&u=https%3A%2F%2Freviews.llvm.org%2FD67968>