[PATCH] D68360: PR41162 Implement LKK remainder and divisibility algorithms

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3966
+/// Computation" (LKK)
+SDValue DAGCombiner::foldUREM(SDNode *node) {
+  SDLoc DL(node);
----------------
TG908 wrote:
> lebedev.ri wrote:
> > This isn't folding, it's lowering.
> > This should be in `TargetLowering.{h,cpp}`
> Good point. I'll move it.
While you are at it, please split `srem` part into a new patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68360/new/

https://reviews.llvm.org/D68360