[PATCH] D68360: PR41162 Implement LKK remainder and divisibility algorithms

Tim Gymnich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 6 05:24:40 PDT 2019


TG908 marked an inline comment as done.
TG908 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3966
+/// Computation" (LKK)
+SDValue DAGCombiner::foldUREM(SDNode *node) {
+  SDLoc DL(node);
----------------
lebedev.ri wrote:
> This isn't folding, it's lowering.
> This should be in `TargetLowering.{h,cpp}`
Good point. I'll move it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68360/new/

https://reviews.llvm.org/D68360





More information about the llvm-commits mailing list