[PATCH] D68471: [scudo][standalone] Correct releaseToOS behavior

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 15:28:04 PDT 2019


morehouse added inline comments.


================
Comment at: lib/scudo/standalone/tests/primary_test.cpp:195
+// test for an error in how the release criteria were computed.
+template <typename Primary> static void testReleaseToOS() {
+  auto Deleter = [](Primary *P) {
----------------
Does this test the two cases mentioned in the description?

  - `< 1` page in use, `> 1` page in free list (should release)
  - `< 1` page in free list (shouldn't release)






Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68471/new/

https://reviews.llvm.org/D68471





More information about the llvm-commits mailing list