[PATCH] D68135: [lit] Set the target-windows feature for any windows environment

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 12:59:07 PDT 2019


mstorsjo added a comment.

In D68135#1695155 <https://reviews.llvm.org/D68135#1695155>, @probinson wrote:

> I'm happy to be wrong about the win32 part.  And eliminating 'target-windows' in favor of using just 'windows' SGTM.


In practice, it's removing `target-windows` in tests where the target availability doesn't really matter, only which host platform it runs on. All of those tests already declared `REQUIRES: system-windows` as well, which should be enough for those tests (this landed in D68449 <https://reviews.llvm.org/D68449>).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68135/new/

https://reviews.llvm.org/D68135





More information about the llvm-commits mailing list