[PATCH] D67968: [TableGen] Introduce a generic automaton (DFA) backend

[James Molloy via llvm-commits]

Hi Steven,

Thanks for reporting this. The fix looks trivial, I shall commit it
tomorrow morning GMT time.

It's interesting that GCC thinks the selected constructor is explicit. I'll
double check the expected behaviour here (but I can simply fix by making
the type explicit).

James

On Fri, 4 Oct 2019, 20:23 Steven Wan via Phabricator, <
reviews at reviews.llvm.org> wrote:

> stevewan added a comment.
>
> Hi,
>
> This is breaking our internal build bots with gcc version 5.4.0. Sample
> error is as follows,
>
>   /home/docker/llvm-project/llvm/unittests/TableGen/AutomataTest.cpp: In
> member function ‘virtual void
> Automata_TupleAutomatonAccepts_Test::TestBody()’:
>
> /home/docker/llvm-project/llvm/unittests/TableGen/AutomataTest.cpp:65:33:
> error: converting to ‘const std::tuple<SymKind, SymKind,
> std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> > >’ from initializer list would use explicit
> constructor ‘constexpr std::tuple< <template-parameter-1-1>
> >::tuple(_UElements&& ...) [with _UElements = {SymKind, SymKind, const char
> (&)[5]}; <template-parameter-2-2> = void; _Elements = {SymKind, SymKind,
> std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >}]’
>          A.add({SK_a, SK_b, "yeet"}));
>                                    ^
>
> Please let us know regarding timeline for a fix. Thanks!
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67968/new/
>
> https://reviews.llvm.org/D67968
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/d1093651/attachment.html>