[PATCH] D68082: [SCEV] Don't add Predicates with OptForSize

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 12:35:50 PDT 2019


hsaito added a comment.

I agree with @Ayal about changing getAsAddRec for OptForSize. In general, it's better to not "Analyze" if we know we won't be using the result of analysis.

In this regard, I do not like pass managers running Analyses for a Transformation pass w/o first letting the Transformation pass inspect the incoming IR, but that's a totally different discussion and I don't have a solution for that problem. Is new pass manager any better there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68082/new/

https://reviews.llvm.org/D68082





More information about the llvm-commits mailing list