[PATCH] D68477: Add an off-by-default option to enable testing for gdb pretty printers.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine created this revision.
saugustine added reviewers: MaskRay, tamur.
Herald added subscribers: llvm-commits, christof, mgorny.
Herald added a project: LLVM.

The current version of the pretty printers are not python3 compatible,
so turn them off by default until sufficiently improved.


Repository:
  rL LLVM

https://reviews.llvm.org/D68477

Files:
  libcxx/CMakeLists.txt
  libcxx/test/CMakeLists.txt


Index: libcxx/test/CMakeLists.txt
===================================================================
--- libcxx/test/CMakeLists.txt
+++ libcxx/test/CMakeLists.txt
@@ -60,12 +60,16 @@
   message(FATAL_ERROR "Expected LIBCXX_TEST_DEPS to be defined")
 endif()
 
-find_program(LIBCXX_GDB gdb)
-if (LIBCXX_GDB)
-  set(LIBCXX_GDB "${LIBCXX_GDB}")
-  message(STATUS "gdb found: ${LIBCXX_GDB}")
-else()
-  message(STATUS "gdb not found. Disabling dependent tests.")
+# Turn this on by default when the pretty printers are python3
+# compatible.
+if(LIBCXX_TEST_GDB_PRETTY_PRINTERS)
+  find_program(LIBCXX_GDB gdb)
+  if (LIBCXX_GDB)
+    set(LIBCXX_GDB "${LIBCXX_GDB}")
+    message(STATUS "gdb found: ${LIBCXX_GDB}")
+  else()
+    message(STATUS "gdb not found. Disabling dependent tests.")
+  endif()
 endif()
 
 if (LIBCXX_INCLUDE_TESTS)
Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -81,6 +81,7 @@
     ${ENABLE_FILESYSTEM_DEFAULT})
 option(LIBCXX_INCLUDE_TESTS "Build the libc++ tests." ${LLVM_INCLUDE_TESTS})
 option(LIBCXX_ENABLE_PARALLEL_ALGORITHMS "Enable the parallel algorithms library. This requires the PSTL to be available." OFF)
+option(LIBCXX_TEST_GDB_PRETTY_PRINTERS "Test gdb pretty printers." OFF)
 
 # Benchmark options -----------------------------------------------------------
 option(LIBCXX_INCLUDE_BENCHMARKS "Build the libc++ benchmarks and their dependencies" ON)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68477.223260.patch
Type: text/x-patch
Size: 1492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/2275c5da/attachment.bin>