[PATCH] D68017: [LLD] [COFF] Always demangle the __imp_ prefix to __declspec(dllimport)

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 11:20:19 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/test/COFF/undefined-symbol-itanium-i386.s:27
+# CHECK-EMPTY:
+# CHECK-NEXT: error: undefined symbol: __declspec(dllimport) _cfunc
 # CHECK-NEXT: >>> referenced by {{.*}}.o:(_f2)
----------------
Fair enough. It's consistent with how we print the other x86 symbols above. (_main, _f1, etc)



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68017/new/

https://reviews.llvm.org/D68017





More information about the llvm-commits mailing list