[PATCH] D68135: [lit] Set the target-windows feature for any windows environment

Fri Oct 4 09:35:02 PDT 2019

mstorsjo added a comment.

In D68135#1694738 <https://reviews.llvm.org/D68135#1694738>, @probinson wrote:

> In D68135#1694106 <https://reviews.llvm.org/D68135#1694106>, @mstorsjo wrote:
>
> > Updated, with a slightly different form of the regex, that also allows the triple to just end at -windows.
> >
> > Alternatively, we could just remove this part of the lit config altogether. There's no other OSes that have target-<os> as a feature (only system-<os> for the host where the test is running), and after D68133 <https://reviews.llvm.org/D68133> and D68136 <https://reviews.llvm.org/D68136>, no tests actually use this feature any longer.
>
>
> In most cases, target restrictions rely on using a component of the triple.  If all Windows-target triples are guaranteed to spell the component 'windows' then `REQUIRES: windows` works, and we don't need target-windows at all.  But I was under the impression that `win32` was used in the triple sometimes?

At least at this point, it seems to use normalized triple names. For input to tools, win32 is a synonym to windows, and "mingw32" as OS name gets normalized to "windows-gnu".

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68135/new/

https://reviews.llvm.org/D68135