[PATCH] D68239: [InstCombine] dropRedundantMaskingOfLeftShiftInput(): change how we deal with mask

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 08:56:16 PDT 2019


spatel added a comment.

In D68239#1693270 <https://reviews.llvm.org/D68239#1693270>, @lebedev.ri wrote:

> I'd be okay with either spliting this up further if wanted, or moving this particular patch
>  into post-commit review mode; the only worrying thing to me here is the `sanitizeUndefsTo()` itself.


I'm a patch minimalist, so if we can split this up, let's do it.
We should not use "sanitize" in the function name because that term already has a special meaning in the clang/LLVM world.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68239/new/

https://reviews.llvm.org/D68239





More information about the llvm-commits mailing list