[PATCH] D68323: [ELF] Wrap things in `namespace lld { namespace elf {`, NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 22:43:02 PDT 2019


MaskRay added a comment.

In D68323#1694050 <https://reviews.llvm.org/D68323#1694050>, @ruiu wrote:

> How about always using elf::write32 instead of endian::write32<E>?


`lld::elf::*` are more commonly used in lld. This will end up with a lot of qualified `write32` `read16` calls. I think we should reduce the number of `using namespace llvm::support::endian;`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68323/new/

https://reviews.llvm.org/D68323





More information about the llvm-commits mailing list