[PATCH] D67696: [tools] Mark output of tools as text if it is really text

Fri Oct 4 01:30:46 PDT 2019

MaskRay added a comment.

In D67696#1675194 <https://reviews.llvm.org/D67696#1675194>, @Kai wrote:

> In D67696#1674254 <https://reviews.llvm.org/D67696#1674254>, @rnk wrote:
>
> > The main effect that I'm aware of here is that this will do CRLF conversion on Windows. Are we sure we really want that? I just did the opposite to TableGen output in rL371683 <https://reviews.llvm.org/rL371683>. In general, I think the majority of tools that write text use OF_Text, so your change makes this minority of tools consistent with the other ones.
>
>
> I am on a platform where the difference between text and binary streams is much greater than on Windows. Therefore I really appreciate the consistency.
>  Yes, I noted your commit. It had surprising effects...

Can you summarize the differences on that platform? z/OS?

While `b` mode is allowed for fopen in ISO C, on POSIX-conforming systems:

> The character 'b' shall have no effect, but is allowed for ISO C standard conformance.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67696/new/

https://reviews.llvm.org/D67696