[PATCH] D68135: [lit] Set the target-windows feature for any windows environment

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 223144.
mstorsjo retitled this revision from "[lit] Set the target-windows feature for mingw triples as well" to "[lit] Set the target-windows feature for any windows environment".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Updated, with a slightly different form of the regex, that also allows the triple to just end at -windows.

Alternatively, we could just remove this part of the lit config altogether. There's no other OSes that have target-<os> as a feature (only system-<os> for the host where the test is running), and after D68133 <https://reviews.llvm.org/D68133> and D68136 <https://reviews.llvm.org/D68136>, no tests actually use this feature any longer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68135/new/

https://reviews.llvm.org/D68135

Files:
  llvm/utils/lit/lit/llvm/config.py


Index: llvm/utils/lit/lit/llvm/config.py
===================================================================
--- llvm/utils/lit/lit/llvm/config.py
+++ llvm/utils/lit/lit/llvm/config.py
@@ -93,7 +93,7 @@
                         'ASAN_OPTIONS', 'detect_leaks=1', append_path=True)
             if re.match(r'^x86_64.*-linux', target_triple):
                 features.add('x86_64-linux')
-            if re.match(r'.*-windows-msvc$', target_triple):
+            if re.match(r'.*-windows(-[^-]+)?$', target_triple):
                 features.add('target-windows')
             if re.match(r'^i.86.*', target_triple):
                 features.add('target-x86')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68135.223144.patch
Type: text/x-patch
Size: 660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/f1b2d448/attachment.bin>