[PATCH] D68406: [update_cc_test_checks] Support 'clang | opt | FileCheck'

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added subscribers: spatel, RKSimon, t.p.northover.
MaskRay added a comment.

There are 30 existing clang CodeGen tests using `%clang ... | opt ... | FileCheck`, but many (`mem2reg`) are used to increase readability while some are probably misuses of `opt`. + at RKSimon who has expressed concerns of maintenance problems on D68230 <https://reviews.llvm.org/D68230>.

+ at t.p.northover and @spatel who have added `opt` to clang tests.



================
Comment at: llvm/utils/update_cc_test_checks.py:99
     else:
       args.clang = os.path.join(args.llvm_bin, 'clang')
   if not distutils.spawn.find_executable(args.clang):
----------------
If a RUN line uses `opt`, you'll need a similar option for `opt` here.

This is named `--opt-binary` in update_test_checks.py, but `--opt` might be more convenient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68406/new/

https://reviews.llvm.org/D68406