[PATCH] D68439: Second attempt to add iterator_range::empty()

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 18:36:44 PDT 2019


jordan_rose created this revision.
jordan_rose added reviewers: RKSimon, sammccall.
Herald added subscribers: llvm-commits, Petar.Avramovic, jsji, dexonsmith, MaskRay, kbarton, hiraditya, nhaehnle, jvesely, nemanjai, arsenm.
Herald added a project: LLVM.

Doing this makes MSVC complain that `empty(someRange)` could refer to either C++17's `std::empty` or LLVM's `llvm::empty`, which previously we avoided via SFINAE because `std::empty` is defined in terms of an `empty` member rather than `begin` and `end`. So, switch callers over to the new method as it is added.

Previously: rL361944 <https://reviews.llvm.org/rL361944>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68439

Files:
  llvm/include/llvm/ADT/iterator_range.h
  llvm/lib/Analysis/LazyCallGraph.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/GlobalISel/InstructionSelector.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp
  llvm/lib/CodeGen/GlobalISel/RegisterBankInfo.cpp
  llvm/lib/CodeGen/MachineModuleInfo.cpp
  llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
  llvm/lib/IR/DebugInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp
  llvm/lib/Target/BPF/BPFAsmPrinter.cpp
  llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
  llvm/lib/Transforms/IPO/PartialInlining.cpp
  llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
  llvm/lib/Transforms/Scalar/NewGVN.cpp
  llvm/lib/Transforms/Utils/PredicateInfo.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68439.223129.patch
Type: text/x-patch
Size: 12741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/982769aa/attachment.bin>


More information about the llvm-commits mailing list