[PATCH] D68418: [test] Remove locale dependency for mri-utf8.test

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 17:52:51 PDT 2019


rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

Out of curiosity, what environment does this currently fail in?



================
Comment at: llvm/test/tools/llvm-ar/mri-utf8.test:17-18
 # include arguments with non-ascii characters.
 # Python on Linux defaults to ASCII encoding unless the
 # environment specifies otherwise, so it is explicitly set.
+RUN: %python -c "assert open(b'\xC2\xA3.txt', 'rb').read() == b'contents\n'"
----------------
This seems to be mostly describing `env LANG=en_US.UTF-8` which is now removed, so the comment can go too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68418/new/

https://reviews.llvm.org/D68418





More information about the llvm-commits mailing list