[PATCH] D68417: [MachineVerify] Verify property of atomic G_LOAD/STORE variants

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 13:48:16 PDT 2019


arsenm added a comment.

Should have test in test/MachineVerifier



================
Comment at: lib/CodeGen/MachineVerifier.cpp:1036-1037
+      if (MMO.isAtomic()) {
+        if (MMO.getAlignment() == 0)
+          report("Atomics must have explicit alignment", MI);
+        if (ValTy.isVector())
----------------
IMO we should remove alignment 0 from all points in the IR and MIR


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68417/new/

https://reviews.llvm.org/D68417





More information about the llvm-commits mailing list