[PATCH] D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 13:40:29 PDT 2019


jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/Loads.cpp:48
+  return false;
 }
 
----------------
While I'm all for making the "getAlign" function explicit eventually, I think it would be good to keep it as is for this patch as there doesn't seem to be a reason to do this here. 

fwiw: I'm behind but eventually I was going to refactor this: D66618



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68398/new/

https://reviews.llvm.org/D68398





More information about the llvm-commits mailing list