[PATCH] D68336: [NFC] Replace 'isDarwin' with 'IsDarwin' based on LLVM naming convention

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 07:18:47 PDT 2019


sfertile accepted this revision.
sfertile added a comment.

My suggestion would be to limit the change to the `PPCAsmPrinter::EmitInstruction` function. We are at the point where I believe we can start removing Darwin support in the PowerPC back end. Fixing the style in `PPCAsmPrinter::EmitInstruction`  make sense since you are modifying the surrounding code and adding new code that uses the variable. Whith the other changes we are probably better to wait and simply remove them, as opposed to renaming them just to remove them shortly after. Either way though the patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68336/new/

https://reviews.llvm.org/D68336





More information about the llvm-commits mailing list