[PATCH] D68385: [llvm-readobj] Replace arch-specific ObjDumper methods by the single `printArchSpecificInfo`

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 05:29:34 PDT 2019


atanasyan created this revision.
atanasyan added reviewers: kongyi, MaskRay, peter.smith.
Herald added subscribers: seiya, rupprecht, kristof.beyls, arichardson, sdardis.
Herald added a project: LLVM.

Initially llvm-readobj supports multiple command line options like `--arm-attributes` and `--mips-plt-got` for display ELF arch-specific information. Now all these options are superseded by the `--arch-specific` one. It makes sense to have a single `printArchSpecificInfo` method in the base `ObjDumper`, and hide all ELF/target specific details in the `ELFDumper::printArchSpecificInfo` override.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68385

Files:
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h
  llvm/tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68385.222989.patch
Type: text/x-patch
Size: 3424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191003/8b723981/attachment.bin>


More information about the llvm-commits mailing list