[PATCH] D68383: [llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 04:58:55 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: seiya, rupprecht.
grimar added a parent revision: D68333: [yaml2obj/obj2yaml] - Add support for SHT_LLVM_ADDRSIG sections..

This patch:

  - Adds a llvm-readobj/llvm-readelf test file for SHT_LLVM_ADDRSIG sections. (we do not have any)
- Enables dumping of SHT_LLVM_ADDRSIG with --all.
- Changes the logic to report a warning instead of an error when something goes wrong during dumping (allows to continue dumping SHT_LLVM_ADDRSIG and other sections on error).
- Refactors a piece of logic to a new `toULEB128Array` helper which might be used for GNU-style dumping implementation.

Depends on: D68333 <https://reviews.llvm.org/D68333>


https://reviews.llvm.org/D68383

Files:
  test/tools/llvm-readobj/elf-addrsig.test
  tools/llvm-readobj/ELFDumper.cpp
  tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68383.222987.patch
Type: text/x-patch
Size: 7759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191003/cb38f9d5/attachment.bin>


More information about the llvm-commits mailing list