[PATCH] D68257: [Support] Add mathematical constants

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/Support/MathExtras.h:69
+                 inv_sqrt3  = 0.57735026918962576450914878050195745564760175127012,
+                 phi        = 1.6180339887498948482045868343656381177203091798058; // https://oeis.org/A001622
+} // namespace numbers
----------------
Please use the correct number of digits (the smallest number of digits required to produce the correct double-precision result). Adding extra digits which don't actually affect the value is confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68257/new/

https://reviews.llvm.org/D68257