[PATCH] D67941: Invalidate assumption cache before outlining.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya marked 2 inline comments as done.
hiraditya added inline comments.


================
Comment at: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll:2
+; REQUIRES: asserts
+; RUN: opt -S -instsimplify -hotcoldsplit -debug < %s 2>&1 | FileCheck %s
 ; RUN: opt -instcombine -hotcoldsplit -instsimplify %s -o /dev/null
----------------
vsk wrote:
> hiraditya wrote:
> > vsk wrote:
> > > hiraditya wrote:
> > > > vsk wrote:
> > > > > Pass '-implicit-check-not=llvm.assume' to FileCheck, so this tests that the assumption in '@f' was removed?
> > > > the llvm.assume will be there in the new function after outlining.
> > > Yes, I see that you've added a check for the llvm.assume in the new (split) function. Please add the -implicit-check-not as well, to test that no llvm.assume is left in the original function.
> > I'm not sure how to make `-implicit-check-not` work when llvm.assume is present in the function. I can use some help, can you share an example? For now I used CHECK to make sure llvm.assume isn't present in the original function.
> Hm, my theory is that the `-implicit-check-not` is probably causing a test failure because it's matching the //declaration// of `@llvm.assume`.
> 
> The CHECK-NOT you've added in the original function's `codeRepl` block probably makes the `implicit-check-not` redundant, though.
> Hm, my theory is that the -implicit-check-not is probably causing a test failure because it's matching the declaration of @llvm.assume.
possible.

> The CHECK-NOT you've added in the original function's codeRepl block probably makes the implicit-check-not redundant, though.

Thanks.


================
Comment at: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll:15
+; CHECK: }
+; CHECK: @llvm.assume
+; CHECK: @f.cold.1(i64 %0)
----------------
vsk wrote:
> Should this be "declare {{.*}}@llvm.assume"?
I'll make these changes before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67941/new/

https://reviews.llvm.org/D67941