[PATCH] D68333: [yaml2obj/obj2yaml] - Add support for SHT_LLVM_ADDRSIG sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 08:00:45 PDT 2019


MaskRay added inline comments.


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:260
+struct AddrsigSymbol {
+  AddrsigSymbol(StringRef N) : Name(N), Index(None){};
+  AddrsigSymbol(llvm::yaml::Hex32 Ndx) : Name(None), Index(Ndx){};
----------------
`{};` -> ` {}`


================
Comment at: test/tools/yaml2obj/elf-llvm-addrsig-section.yaml:199
+# LINK:      Link:
+# LINK-SAME: 123{{$}}
+
----------------
Right shift 123{{$}}


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68333/new/

https://reviews.llvm.org/D68333





More information about the llvm-commits mailing list