[PATCH] D66991: [PowerPC] Fix SH field overflow issue

Wed Oct 2 07:29:19 PDT 2019

jsji accepted this revision as: jsji.
jsji added a comment.

LGTM. Thanks for the patience during review.

================
Comment at: llvm/test/CodeGen/PowerPC/sh-overflow.mir:19
+    ; Ensure we do not attempt to transform this into srwi $r3, $r3, 0 in the
+    ; form specified by ISA 3.0b (rlwinm $r3, $r3, 32 - 0, 0, 31)
+
----------------
This might be a little confusing -- why avoiding transform into a form in ISA 3.0b , which normally is supposed to be correct?

yes, I think you are trying to express that ISA 3.0b also have the bug when describing extended mnemonics of `srwi` and `srdi`. In that case, I think we should contact the ISA team to fix it. We don't need to emphasis that in the comments here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66991/new/

https://reviews.llvm.org/D66991